Skip to content

Conversation

@duswie
Copy link
Contributor

@duswie duswie commented Nov 16, 2024

The Imagick build did not support the AVIF format due to missing encoder dependencies. Generated .avif files were empty without producing an error.

This is fixed by building imagick with upgraded and additional dependencies (AOM Encoder) and more extensive tests are added.

@duswie duswie changed the title Imagick: build with support for AVIF format with aim encoder Imagick: build with support for AVIF format by aom encoder Nov 16, 2024
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@mnapoli
Copy link
Member

mnapoli commented Dec 1, 2024

Does this increase the layer size by a lot?

@duswie
Copy link
Contributor Author

duswie commented Dec 4, 2024

It's ~100MB now.
Do you think this is reasonable, or should we make it a separate layer like “imagick-full”?
Bildschirmfoto 2024-12-04 um 20 10 41

@mnapoli
Copy link
Member

mnapoli commented Dec 4, 2024

Sorry I meant the Lambda layer (the zip file), not the Docker layers.

@duswie
Copy link
Contributor Author

duswie commented Dec 5, 2024

Got you. The compressed zip files size is only increased by 514kB (+ 1,5%) to 36,2 MB.

@Nyholm
Copy link
Collaborator

Nyholm commented Dec 11, 2024

Can you please rebase this and I'll be happy to merge.

@jongotlin
Copy link

Thank you @duswie! I tested this and can confirm it also solves the libheif issue with converting heic-images created in ios 18.

@Nyholm Nyholm merged commit 8561523 into brefphp:master Mar 7, 2025
2 checks passed
@Nyholm
Copy link
Collaborator

Nyholm commented Mar 7, 2025

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants