Support multiple cookies with API Gateway v2#841
Merged
Conversation
mnapoli
commented
Jan 18, 2021
| } | ||
| } | ||
|
|
||
| return array_change_key_case($responseHeaders, CASE_LOWER); |
Member
Author
There was a problem hiding this comment.
Headers are no returned unchanged because we normalize them later in any case. That simplifies the code.
| $response = $this->handleRequest($httpEvent, $context); | ||
|
|
||
| if ($httpEvent->isFormatV2()) { | ||
| return $response->toApiGatewayFormatV2(); |
Member
Author
There was a problem hiding this comment.
I've added a completely separate method to avoid too many ifs and branches.
mnapoli
added a commit
that referenced
this pull request
Feb 14, 2023
Support multiple cookies with API Gateway v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #818
Replaces #820
This PR allows apps to set multiple cookies in HTTP responses when using API Gateway v2.
Previously this wasn't possible because v2 does not support "multi-value headers". But they added a specific
cookiesfield which we can use to set multiple cookies.