Skip to content

Fix type for timeout option #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type for timeout option #266

wants to merge 1 commit into from

Conversation

Shiv-hcr
Copy link

@Shiv-hcr Shiv-hcr commented Aug 4, 2025 •
edited
Loading

There is a runtime check which will throw an error if timeout is set to true, along the lines of:

error: Job #1 named "exampleJob" had an invalid timeout of true

This minor tweak will ensure type safety at build/dev time too.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@Shiv-hcr
Fix type for timeout option
2c56cb5 
There is a runtime check which will throw an error if timeout is set to true, along the lines of:

error: Job breejs#1 named "exampleJob" had an invalid timeout of true

Now its type safe at runtime and build/dev time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Shiv-hcr