WIP: Allow scoping rate-limits to specific resources and paths #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcgruenhage
force-pushed
the
fine-grained-rate-limits
branch
2 times, most recently
from
7c57cff
to
5058bac
Compare
jcgruenhage
force-pushed
the
fine-grained-rate-limits
branch
from
5058bac
to
f0df198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80, and is based on #82.
Still to do:
Future opportunities for improvement:
sorting, and then again when converting from the config format into the
runtime format of the rate limit. The solution I'd suggest here is moving
the parsing of the duration to the time when the config is loaded with
serde, using https://serde.rs/field-attrs.html#with. This makes the error
messages nicer as well, as it automatically gives us benefits like including
the location in the file where stuff went wrong.