Fix compatibility with json gem 2.11.0#98
Merged
nglx merged 1 commit intobreamware:masterfrom Jun 11, 2025
Merged
Conversation
Apparently, `JSON.unparse` has been nodoc/deprecated for 16 years and now it was removed in the latest release. JSON.generate has been around since forever, so it can just be used in all cases (especially considering it's Ruby 3.2# only)
Contributor
Author
|
json 2.11.1 was released already with these old aliases added back so for now it just emits a deprecation warning instead of breaking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON.unparsehas been nodoc/deprecated for 16 years and now it was removed in the latest release.JSON.generatehas been around since forever, so it can just be used in all cases (especially considering it's Ruby 3.2 only)Ref: ruby/json#775. It might be added back, but it will at least be deprecated.