Skip to content
This repository was archived by the owner on Jul 31, 2020. It is now read-only.

Same batch Create + Update records should resolve to Create#97

Merged
ayumi merged 1 commit intostagingfrom
fix/merge-batched-record-actions
Jun 8, 2017
Merged

Same batch Create + Update records should resolve to Create#97
ayumi merged 1 commit intostagingfrom
fix/merge-batched-record-actions

Conversation

@ayumi
Copy link
Contributor

@ayumi ayumi commented Jun 7, 2017 •
edited
Loading

Fix #91

Also:

  • Fix bug where recordUtil.resolveRecords() would mutate in-place.
  • Improve human level of "Ignoring [record action] of object [1,2,3]" so it says the action string instead of number.

Bonus test plan:

  1. yarn dist into browser-laptop
  2. run browser-laptop and sync to the sync profile of Renamed folder never fetches #91:
squalider piccalilli mutate decomposability
waterily nonaligned watershed homeward
aidman tat nobleman filling
chromaticism copolymerizing prythee gonococci
  1. confirm the bookmark folder "123456"

cc @SergeyZhukovsky

@ayumi
Same batch Create + Update records should resolve to Create
865c2e5 
Also fixes bug where recordUtil.resolveRecords() would mutate in-place.

Fix #91

Auditors: @diracdeltas
@ayumi ayumi requested a review from diracdeltas June 7, 2017 21:21
diracdeltas
diracdeltas approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test plan worked. lgtm assuming travis is stoked

@ayumi ayumi merged commit 9325e6d into staging Jun 8, 2017
@ayumi ayumi deleted the fix/merge-batched-record-actions branch June 8, 2017 00:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@diracdeltas diracdeltas diracdeltas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Renamed folder never fetches

2 participants

@ayumi @diracdeltas