This repository was archived by the owner on Jul 31, 2020. It is now read-only.
Conversation
Member
diracdeltas
commented
Oct 5, 2017
diracdeltas
commented
- migrates to using the shared crypto library https://github.com/brave/crypto
- updates some outdated Node modules
- uses npm with package-lock instead of yarn by default; see reasons in 0fffc14
Yarn kept breaking for me since it was installed from homebrew and required the homebrew version of npm, which sometimes doesn't work with browser-laptop. IMO most of its important functionality is available in NPM 5+. This repo should not require devs to have Yarn.
diracdeltas
commented
Oct 5, 2017
| * @param {Uint8Array} nonce | ||
| * @param {Uint8Array} secretboxKey | ||
| * @returns {Uint8Array|boolean} | ||
| * @returns {Uint8Array?} |
Member
Author
There was a problem hiding this comment.
this is a change from tweetnacl 1.0.0 - see dchest/tweetnacl-js#132. AFAIK it only affected tests (which were fixed)
ayumi
approved these changes
Oct 6, 2017
Contributor
ayumi
left a comment
ayumi
left a comment
There was a problem hiding this comment.
🦇 browser-laptop sync tests pass the same amount with this patch
Member
Author
|
@ayumi yay, feel free to merge and do a sync release whenever u want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.