-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Button type definitions #42
Conversation
d8454af
to
0827d0c
Compare
Hey @AlanBreck do we want to try and land this? |
Sounds good to me!! |
73d13e2
to
289188d
Compare
All right, I've fixed the merge conflict and the formatting. Anything else need doing? |
Not that I can think of. The only thing that would be nice in the future is if there's any opportunity to simply for future component authors. No idea how, though. 😂 |
Yeah, It's definitely pretty awkward at the moment - hopefully Svelte improves this :D |
@petemill what are your thoughts on this? |
289188d
to
bef57e7
Compare
0ab800c
to
8c026db
Compare
This does the following:
It does not:
@petemill what do you think about this as an approach?