This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Connect to 127.0.0.1, not localhost, for tor control channel. Tweak error branches for clarity. #14554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May fix Brave's failure to connect to Tor on some networks, with the
following symptom printed to the console:
tor: control socket error: Error: getaddrinfo ENOTFOUND localhost undefined:55219
tor: control socket error: Error: getaddrinfo ENOTFOUND localhost undefined:55219
tor: control socket closed early
Auditors: @diracdeltas
Test Plan:
Sneak into David's house and try running Brave on his home network.
If he has reconfigured it, invent a time machine to revert it to the
previous state where it didn't work.
|
@riastradh-brave is there an issue this is fixing? |
bsclifton
approved these changes
Jun 26, 2018
bsclifton
pushed a commit
that referenced
this pull request
Jun 26, 2018
…rror branches for clarity. (#14554) * Use host 127.0.0.1 explicitly, instead of defaulting to localhost. May fix Brave's failure to connect to Tor on some networks, with the following symptom printed to the console: tor: control socket error: Error: getaddrinfo ENOTFOUND localhost undefined:55219 tor: control socket error: Error: getaddrinfo ENOTFOUND localhost undefined:55219 tor: control socket closed early Auditors: @diracdeltas Test Plan: Sneak into David's house and try running Brave on his home network. If he has reconfigured it, invent a time machine to revert it to the previous state where it didn't work. * Make early error message distinct. * Pass error along to control connection destruction for consistency.
|
@diracdeltas Informally, yes, but no issue was filed for it. I can file an issue and close it once we confirm it's fixed. |
bsclifton
pushed a commit
that referenced
this pull request
Jun 27, 2018
…rror branches for clarity. (#14554) * Use host 127.0.0.1 explicitly, instead of defaulting to localhost. May fix Brave's failure to connect to Tor on some networks, with the following symptom printed to the console: tor: control socket error: Error: getaddrinfo ENOTFOUND localhost undefined:55219 tor: control socket error: Error: getaddrinfo ENOTFOUND localhost undefined:55219 tor: control socket closed early Auditors: @diracdeltas Test Plan: Sneak into David's house and try running Brave on his home network. If he has reconfigured it, invent a time machine to revert it to the previous state where it didn't work. * Make early error message distinct. * Pass error along to control connection destruction for consistency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests