This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 970
Adapt package_tor.js to the mingw build of tor. #14507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
reviewed
Jun 21, 2018
@@ -1,7 +1,6 @@ | |||
const execute = require('./lib/execute') | |||
const path = require('path') | |||
const fs = require('fs') | |||
const unzip = require('unzip') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this was the only dependent on unzip, please run npm uninstall --save-dev unzip
to remove it as a dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I might have screwed up the package-lock.json file. Should maybe recreate it. |
diracdeltas
suggested changes
Jun 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to refresh package-lock.json to get rid of extraneous changes
- Just a static .exe, not a .zip of dynamic .exe and .dll deps. - Same version as everything else. - [ ] **FIXME: Need the actual hash.** fix #14291 fix #14449 Auditors: @jumde @diracdeltas Test Plan: 1. Install Brave on Windows. 2. Launch it. 3. Browse around in a tab with Tor enabled.
jumde
force-pushed
the
riastradh-tor-mingwbinary
branch
from
June 22, 2018 05:02
1b06fe9
to
ff9e178
Compare
diracdeltas
approved these changes
Jun 22, 2018
diracdeltas
pushed a commit
that referenced
this pull request
Jun 22, 2018
* Adapt package_tor.js to the mingw build of tor. fix #14463 Auditors: @jumde @diracdeltas Test Plan: 1. Install Brave on Windows. 2. Launch it. 3. Browse around in a tab with Tor enabled. * No more need for unzip. * Updating hash for windows binary * update package-lock
bsclifton
pushed a commit
that referenced
this pull request
Jun 23, 2018
* Adapt package_tor.js to the mingw build of tor. fix #14463 Auditors: @jumde @diracdeltas Test Plan: 1. Install Brave on Windows. 2. Launch it. 3. Browse around in a tab with Tor enabled. * No more need for unzip. * Updating hash for windows binary * update package-lock
bsclifton
pushed a commit
that referenced
this pull request
Jun 25, 2018
* Adapt package_tor.js to the mingw build of tor. fix #14463 Auditors: @jumde @diracdeltas Test Plan: 1. Install Brave on Windows. 2. Launch it. 3. Browse around in a tab with Tor enabled. * No more need for unzip. * Updating hash for windows binary * update package-lock
bsclifton
pushed a commit
that referenced
this pull request
Jun 26, 2018
* Adapt package_tor.js to the mingw build of tor. fix #14463 Auditors: @jumde @diracdeltas Test Plan: 1. Install Brave on Windows. 2. Launch it. 3. Browse around in a tab with Tor enabled. * No more need for unzip. * Updating hash for windows binary * update package-lock
bsclifton
pushed a commit
that referenced
this pull request
Jun 27, 2018
* Adapt package_tor.js to the mingw build of tor. fix #14463 Auditors: @jumde @diracdeltas Test Plan: 1. Install Brave on Windows. 2. Launch it. 3. Browse around in a tab with Tor enabled. * No more need for unzip. * Updating hash for windows binary * update package-lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14463
Auditors: @jumde @diracdeltas
Test Plan:
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests