Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adapt package_tor.js to the mingw build of tor. #14507

Merged
merged 4 commits into from
Jun 22, 2018

Conversation

riastradh-brave
Copy link
Contributor

@riastradh-brave riastradh-brave commented Jun 21, 2018

  • Just a static .exe, not a .zip of dynamic .exe and .dll deps.
  • Same version as everything else.
  • FIXME: Need the actual hash.

fix #14463

Auditors: @jumde @diracdeltas

Test Plan:

  1. Install Brave on Windows.
  2. Launch it.
  3. Browse around in a tab with Tor enabled.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@@ -1,7 +1,6 @@
const execute = require('./lib/execute')
const path = require('path')
const fs = require('fs')
const unzip = require('unzip')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this was the only dependent on unzip, please run npm uninstall --save-dev unzip to remove it as a dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riastradh-brave
Copy link
Contributor Author

I think I might have screwed up the package-lock.json file. Should maybe recreate it.

Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to refresh package-lock.json to get rid of extraneous changes

riastradh-brave and others added 3 commits June 21, 2018 22:01
- Just a static .exe, not a .zip of dynamic .exe and .dll deps.
- Same version as everything else.
- [ ] **FIXME: Need the actual hash.**

fix #14291
fix #14449

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.
@jumde jumde force-pushed the riastradh-tor-mingwbinary branch from 1b06fe9 to ff9e178 Compare June 22, 2018 05:02
@diracdeltas diracdeltas merged commit ed07aaa into tor/0.23.x Jun 22, 2018
@diracdeltas diracdeltas deleted the riastradh-tor-mingwbinary branch June 22, 2018 06:00
diracdeltas pushed a commit that referenced this pull request Jun 22, 2018
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
bsclifton pushed a commit that referenced this pull request Jun 23, 2018
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
bsclifton pushed a commit that referenced this pull request Jun 25, 2018
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
bsclifton pushed a commit that referenced this pull request Jun 26, 2018
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
bsclifton pushed a commit that referenced this pull request Jun 27, 2018
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants