Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
docs: fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
JayKan committed Jan 23, 2018
1 parent ccd3684 commit 8dd9843
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/autoUpdates.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The built dmg binary requires its components to be digitally signed before the u

1. Create and download developer certificate from developer.apple.com

The certificate will be in the form of a .cer file. The cerficate will need to be added to the keychain via the Keychain Access program. Add the certificate in the login section. Note: The Keychain Access program is included in macOS and will by default handle issued .cert files.
The certificate will be in the form of a .cer file. The certificate will need to be added to the keychain via the Keychain Access program. Add the certificate in the login section. Note: The Keychain Access program is included in macOS and will by default handle issued .cert files.

2. Ensure that a private keys exists and is associated with the certificate installed in step 1. A sub section of the certificate will be shown and tagged as a private key. Generating the private key (.p12 file) is a multi-stop process that requires access to the developer.apple.com portal and access to your development machine. It is described in detail at [generating a p12 file](http://appfurnace.com/2015/01/how-do-i-make-a-p12-file/). If you already have access to the private, import it into Keychain Access ensuring it is associated with the Developer certificate.

Expand Down
6 changes: 3 additions & 3 deletions docs/tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ Or most of the time just append `.debug()` to a series of commands.
This will pause the browser from running tests, and you can open up browser dev tools or content dev tools to inspect logs, console, and other things.
You should act fast or else adjust the timeout or the test will fail though.

To get browser process logs, run tests with the `BRAVE_TEST_BROWSER_LOGS=1` envrionment variable.
To get renderer process logs, run tests with the `BRAVE_TEST_RENDERER_LOGS=1` envrionment variable.
To get browser process logs, run tests with the `BRAVE_TEST_BROWSER_LOGS=1` environment variable.
To get renderer process logs, run tests with the `BRAVE_TEST_RENDERER_LOGS=1` environment variable.

### Avoiding intermittent failures in automated UI tests

Expand All @@ -181,5 +181,5 @@ Here are some strategies to avoid intermittent failures:
- Never assume that state will be reflected right away, for example if loading a URL, don't assume an entry is already added to the app's `sites` state. Instead use `waitForSiteEntry`.
- Enable verbose mode as described above to get better information.
- Prefer adding Webdriver IO commands when possible, especially for waiting operations, and add logging to them.
- When possible, make the Webdriver commands you add wait for a result. Example: Changing a seting also waits for the changed value to be reflected in state.
- When possible, make the Webdriver commands you add wait for a result. Example: Changing a setting also waits for the changed value to be reflected in state.
- Look out for elements that can be disabled temporarily, in this case, a click could for example happen while the element is still disabled.
2 changes: 1 addition & 1 deletion docs/translations.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ We manage all of our translations using Transifex. Here's how you can get starte
At this point, you are ready to join and help with translations or you can request a language.
- Visit https://www.transifex.com/brave/brave-laptop/
- In the top right, you can click "Join team".
- You can specify the lanaguages you speak OR request a language which is not currently provided
- You can specify the languages you speak OR request a language which is not currently provided
- One of our contributors will be able to approve your access.

## How does translated text get back into the GitHub repository?
Expand Down

0 comments on commit 8dd9843

Please sign in to comment.