Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More query string trackers #9733

Merged
merged 3 commits into from
Aug 12, 2021
Merged

More query string trackers #9733

merged 3 commits into from
Aug 12, 2021

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Aug 12, 2021

Resolves brave/brave-browser#17451 and brave/brave-browser#17452.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open https://brave.com/?rb_clickid=1234567890abcdef and confirm that the URL bar doesn't contain the rb_clickid parameter.
  2. Open https://brave.com/?s_cid=abcdef1234567890 and confirm that the URL bar doesn't contain the s_cid parameter.

@fmarier fmarier requested a review from iefremov August 12, 2021 02:13
@fmarier fmarier self-assigned this Aug 12, 2021
@fmarier fmarier merged commit aedcdf3 into master Aug 12, 2021
@fmarier fmarier deleted the more-query-string-trackers branch August 12, 2021 17:27
@fmarier fmarier added this to the 1.30.x - Nightly milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out rb_clickid from URLs
2 participants