-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip initialization of referral system for the default referral code #8103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test Plan
|
This reverts commit f1992ac.
Updated approach after talking out with @aekeus and @jsecretan 😄 Much more simple |
e8ab576
to
b299160
Compare
Created security review - we'll need approval here before we can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I like your test plan ;).
Updated test plan to assume that this patch is included in the build 😄 Original steps by @jonathansampson help prove the code path works (without having this patch present) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified
Verified using
Verification PASSED on
Example of the issue originally occurring on Examples if the issue being fixed via
|
Fixes brave/brave-browser#14428
Security review here:
https://github.com/brave/security/issues/349
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See #8103 (comment)