//net url functions takeing string_view

Upstream util functions for URL manipulation that used to take a
pointer/size pair, have been updated to take a `string_view` and this
change corrects all the callers in Brave accordingly.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/cc4d2b28d2c37283f8532d5caa042ff1fb2bfdb3

commit cc4d2b28d2c37283f8532d5caa042ff1fb2bfdb3
Author: David Benjamin <davidben@chromium.org>
Date:   Mon Oct 2 23:12:04 2023 +0000

    Replace some ptr/len APIs in //url with std::string_view

    This is both safer and more convenient.

browser/brave_wallet/brave_wallet_ethereum_chain_browsertest.cc

@@ -84,7 +84,7 @@ const char kScriptRunEmptyAndCheckChainResult[] = R"(
 
 std::string EncodeQuery(const std::string& query) {
   url::RawCanonOutputT<char> buffer;
-  url::EncodeURIComponent(query.data(), query.size(), &buffer);
+  url::EncodeURIComponent(query, &buffer);
   return std::string(buffer.data(), buffer.length());
 }
 

browser/ntp_background/custom_background_file_manager.h

@@ -96,9 +96,8 @@ class CustomBackgroundFileManager final {
         const auto path = value.path().substr(1);
         DCHECK(!path.empty()) << "URL path is empty " << value;
         url::RawCanonOutputT<char16_t> decoded_value;
-        url::DecodeURLEscapeSequences(path.data(), path.length(),
-                                      url::DecodeURLMode::kUTF8OrIsomorphic,
-                                      &decoded_value);
+        url::DecodeURLEscapeSequences(
+            path, url::DecodeURLMode::kUTF8OrIsomorphic, &decoded_value);
         value_ = base::UTF16ToUTF8(
             std::u16string(decoded_value.data(), decoded_value.length()));
       } else {
@@ -136,7 +135,7 @@ class CustomBackgroundFileManager final {
         // Do percent encoding and compose it with base url so that it can
         // be used as webui data url.
         url::RawCanonOutputT<char> encoded;
-        url::EncodeURIComponent(value_.c_str(), value_.length(), &encoded);
+        url::EncodeURIComponent(value_, &encoded);
         return GURL(ntp_background_images::kCustomWallpaperURL +
                     std::string(encoded.data(), encoded.length()));
       } else {

browser/ui/views/brave_player/brave_player_action_icon_view.cc

@@ -36,17 +36,9 @@ GURL GetPlayerURL(content::WebContents* web_contents) {
       url.has_query()) {
     if (std::string video_id; net::GetValueForKeyInQuery(url, "v", &video_id)) {
       url::RawCanonOutputT<char> encoded_video_id;
-      // TODO(sko) In the latest upstream code, these are refactored to use
-      // std::string_view directly. So the following code should be
-      //
-      // url::EncodeURIComponent(video_id, &encoded_video_id);
-      // return GURL(base::StrCat({kBravePlayerURL, "youtube/",
-      //   encoded_video_id.view()}));
-      url::EncodeURIComponent(video_id.data(), video_id.size(),
-                              &encoded_video_id);
+      url::EncodeURIComponent(video_id, &encoded_video_id);
       return GURL(base::StrCat({brave_player::kBravePlayerURL, "youtube/",
-                                std::string_view(encoded_video_id.data(),
-                                                 encoded_video_id.length())}));
+                                encoded_video_id.view()}));
     }
   }
   return {};

components/brave_vpn/browser/brave_vpn_service.cc

@@ -581,8 +581,7 @@ void BraveVpnService::OnPrepareCredentialsPresentation(
       net::cookie_util::ParseCookieExpirationTime(credential_cookie.Expires());
   url::RawCanonOutputT<char16_t> unescaped;
   url::DecodeURLEscapeSequences(
-      encoded_credential.data(), encoded_credential.size(),
-      url::DecodeURLMode::kUTF8OrIsomorphic, &unescaped);
+      encoded_credential, url::DecodeURLMode::kUTF8OrIsomorphic, &unescaped);
   std::string credential;
   base::UTF16ToUTF8(unescaped.data(), unescaped.length(), &credential);
   if (credential.empty()) {

components/brave_wayback_machine/brave_wayback_machine_utils.cc

@@ -51,8 +51,7 @@ GURL FixupWaybackQueryURL(const GURL& url) {
   for (net::QueryIterator it(url); !it.IsAtEnd(); it.Advance()) {
     std::string key = std::string(it.GetKey());
     url::RawCanonOutputW<1024> canonOutput;
-    url::DecodeURLEscapeSequences(key.c_str(), key.length(),
-                                  url::DecodeURLMode::kUTF8OrIsomorphic,
+    url::DecodeURLEscapeSequences(key, url::DecodeURLMode::kUTF8OrIsomorphic,
                                   &canonOutput);
     const std::string decoded_key = base::UTF16ToUTF8(
         std::u16string_view(canonOutput.data(), canonOutput.length()));