Fixes a crash on a tab back gesture on Android 14 #19766
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#31939
That's a temporary fix for Android 14 till we migrate to
Target: Android 14 (API 34)
. That is scheduled to happen on chromium 117 update. Chrome builds it's browser with Android 14 target already, most likely they change a gn var for thatandroid_sdk_version
. I've tried to use 34 there but there are diff problems appear that needs to be addressed. After discussions with @samartnik we decided to make that temp patch looking on a fact that Android 14 is still in beta and revert it in chromium 117 where there are no issues anymore.A follow up issue to revert the patch brave/brave-browser#32365
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
It's described in the original issue.