-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap page available for locked wallet #18998
Conversation
@@ -245,7 +245,7 @@ public static void openBuySendSwapActivity( | |||
if (activityType == BuySendSwapActivity.ActivityType.SWAP_V2) { | |||
try { | |||
BraveActivity.getBraveActivity().openNewOrSelectExistingTab( | |||
BraveActivity.BRAVE_SWAP_URL); | |||
BraveActivity.BRAVE_SWAP_URL, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to reload here? Is it because on re-opening the app we want to make sure we have the current lock state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for situation when you tried to open browser tab with address brave://wallet/swap
and got empty page
but then you unlocked the wallet and pressed the swap
button.
without refresh, you will see the same empty tab brave://wallet/swap
But if you refresh it, all the info will be displayed
Signed-off-by: Vadym Struts <vstruts@brave.com>
d6209d4
to
166fd69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Fixed wallet lock detection when
brave://wallet/*
pages openingResolves brave/brave-browser#31236
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Preconditions:
Steps: