Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap page available for locked wallet #18998

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

vadimstruts
Copy link
Collaborator

@vadimstruts vadimstruts commented Jun 22, 2023

Fixed wallet lock detection when brave://wallet/* pages opening

Resolves brave/brave-browser#31236

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Preconditions:

  • initialized wallet

Steps:

  1. Unlock wallet
  2. Go to swap page
  3. Close the browser by clicking "Exit"
  4. Open browser
  5. Swap page is not available, i.e. there is no any wallet information displayed
  6. Unlock wallet
  7. Go to swap page (by clicking the swap button)
  8. Swap page opened, all related information displayed

@vadimstruts vadimstruts changed the title fix for the opening swap page for the locked wallet Swap page available for locked wallet Jun 22, 2023
@@ -245,7 +245,7 @@ public static void openBuySendSwapActivity(
if (activityType == BuySendSwapActivity.ActivityType.SWAP_V2) {
try {
BraveActivity.getBraveActivity().openNewOrSelectExistingTab(
BraveActivity.BRAVE_SWAP_URL);
BraveActivity.BRAVE_SWAP_URL, true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to reload here? Is it because on re-opening the app we want to make sure we have the current lock state?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for situation when you tried to open browser tab with address brave://wallet/swap and got empty page
but then you unlocked the wallet and pressed the swap button.
without refresh, you will see the same empty tab brave://wallet/swap
But if you refresh it, all the info will be displayed

Signed-off-by: Vadym Struts <vstruts@brave.com>
@vadimstruts vadimstruts force-pushed the blank_swap_page_if_wallet_locked branch from d6209d4 to 166fd69 Compare June 23, 2023 08:38
@vadimstruts vadimstruts marked this pull request as ready for review June 23, 2023 08:43
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@vadimstruts vadimstruts merged commit 6223e41 into master Jun 23, 2023
@vadimstruts vadimstruts deleted the blank_swap_page_if_wallet_locked branch June 23, 2023 21:19
@github-actions github-actions bot added this to the 1.55.x - Nightly milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap page available for locked wallet
3 participants