Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show domain info when signing messages #16935

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Jan 31, 2023

Resolves brave/brave-browser#28048

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Sing message ui should show domain field content for v3 and v4 signature types

Desktop: #16935 (comment)
Android:
image

@supermassive supermassive requested review from a team as code owners January 31, 2023 09:53
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 31, 2023
@supermassive supermassive changed the title Backend support Show domain info when signing messages Jan 31, 2023
@supermassive supermassive force-pushed the domain_info_when_signing branch from fe5037d to 0b18ee0 Compare February 1, 2023 07:34
@brave brave deleted a comment from github-actions bot Feb 1, 2023
@onyb
Copy link
Member

onyb commented Feb 1, 2023

This what the panel looks like after my UI updates in b3cf58e.

Personal Sign Sign Typed Data V3 Sign Typed Data V4 Sign Typed Data V4 (⚠️)

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Front-end

@yrliou
Copy link
Member

yrliou commented Feb 1, 2023

Added @SergeyZhukovsky as a reviewer for Android commit.

<message name="IDS_WALLET_SIGN_MESSAGE_DETAILS_DOMAIN_SECTION" desc="A domain section template of sign message details">
<ph name="BEGIN_BOLD">&lt;b&gt;</ph>Domain:<ph name="END_BOLD">&lt;/b&gt;</ph><ph name="BREAK">&lt;br&gt;</ph><ph name="ESCAPED_DOMAIN_TEXT">%1$s</ph><ph name="BREAK">&lt;br&gt;</ph>
</message>
<message name="IDS_WALLET_SIGN_MESSAGE_DETAILS_MESSAGE_SECTION" desc="A message section template of sign message details">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add translateable="false" for both strings as nothing to translate there.

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the small comment I left for Android. Otherwise Android part ++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive force-pushed the domain_info_when_signing branch from c7ea56f to a03f83c Compare February 2, 2023 02:48
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive force-pushed the domain_info_when_signing branch from a03f83c to b2d523d Compare February 2, 2023 05:46
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive enabled auto-merge (squash) February 2, 2023 06:39
@supermassive supermassive merged commit 6384e19 into master Feb 2, 2023
@supermassive supermassive deleted the domain_info_when_signing branch February 2, 2023 07:36
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 2, 2023
@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2023

Verification passed on

Brave 1.50.3 Chromium: 110.0.5481.52 (Official Build) nightly (64-bit)
Revision 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS Linux
  • Verified domain info is shown on signing messages for v3/v4 messages
Personal Sign Sign Type V3 Sign Type V4
image image image

Verification passed on Oppo Reno 5 with Android 13 running 1.50.3 x64 Nightly build

  • Verified domain info is shown on signing messages for v3/v4 messages
16935.mp4

kjozwiak pushed a commit that referenced this pull request Feb 4, 2023
kjozwiak pushed a commit that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP712Domain data should be displayed
8 participants