-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show domain info when signing messages #16935
Conversation
components/brave_wallet_ui/components/extension/sign-panel/index.tsx
Outdated
Show resolved
Hide resolved
fe5037d
to
0b18ee0
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Front-end
Added @SergeyZhukovsky as a reviewer for Android commit. |
<message name="IDS_WALLET_SIGN_MESSAGE_DETAILS_DOMAIN_SECTION" desc="A domain section template of sign message details"> | ||
<ph name="BEGIN_BOLD"><b></ph>Domain:<ph name="END_BOLD"></b></ph><ph name="BREAK"><br></ph><ph name="ESCAPED_DOMAIN_TEXT">%1$s</ph><ph name="BREAK"><br></ph> | ||
</message> | ||
<message name="IDS_WALLET_SIGN_MESSAGE_DETAILS_MESSAGE_SECTION" desc="A message section template of sign message details"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add translateable="false"
for both strings as nothing to translate there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the small comment I left for Android. Otherwise Android part ++
A Storybook has been deployed to preview UI for the latest push |
c7ea56f
to
a03f83c
Compare
A Storybook has been deployed to preview UI for the latest push |
a03f83c
to
b2d523d
Compare
A Storybook has been deployed to preview UI for the latest push |
Uplift of #16935 (squashed) to beta
Uplift of #16935 (squashed) to release
Resolves brave/brave-browser#28048
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Sing message ui should show domain field content for v3 and v4 signature types
Desktop: #16935 (comment)
![image](https://user-images.githubusercontent.com/168356/215978002-79d8b070-9118-44d9-804f-8379be40b7b1.png)
Android: