Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate crypto widgets visibility in NTP (uplift to 1.33.x) #11288

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Migrate crypto widgets visibility in NTP (uplift to 1.33.x) #11288

merged 1 commit into from
Nov 28, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 25, 2021 •
edited by kjozwiak
Loading

Uplift of #11266
Resolves brave/brave-browser#19708

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong
Migrate crypto widgets visibility in NTP (#11266)
8f4ef8e 
* Migrate crypto widgets visibility in NTP

fix brave/brave-browser#19708

Migration is done once in the first NTP loading.

For new users, all crypto widgets are hidden by default.
For existing users, if current foremost widget is crypto widget,
only it is visible and others are hidden.
And, authed widgets are visible regardless of its position in widget stack
After migration, user can control crypto widget's visibility from gallery.

To make all crypto widgets hidden by default, each pref's default
value is not changed. Their default prefs is still "true".
As their visibility are managed by prefs and widget order is managed in local
storage, it's difficult to start migration from c++. If default is changed
to false, it's very difficult to determine whether foremost widget is crypto
or not in the NTP webui.
@simonhong simonhong requested a review from a team November 25, 2021 05:12
@kjozwiak kjozwiak added this to the 1.33.x - Beta milestone Nov 27, 2021
kjozwiak
kjozwiak approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.33.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #11266 (comment).

@kjozwiak kjozwiak merged commit 25b7fa4 into 1.33.x Nov 28, 2021
@kjozwiak kjozwiak deleted the pr11266_ntp_crypto_widget_1.33.x branch November 28, 2021 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@simonhong @kjozwiak @brave-builds