git push via https now works

script/lib/github.py

@@ -269,13 +269,19 @@ def get_title_from_first_commit(path, branch_to_compare):
         return title_list[0]
 
 
-def push_branches_to_remote(path, branches_to_push, dryrun=False):
+def push_branches_to_remote(path, branches_to_push, dryrun=False, token=None):
     if dryrun:
         print('[INFO] would push the following local branches to remote: ' + str(branches_to_push))
     else:
         with scoped_cwd(path):
             for branch_to_push in branches_to_push:
                 print('- pushing ' + branch_to_push + '...')
                 # TODO: if they already exist, force push?? or error??
-                # NOTE: this fails if clone was done via https
-                execute(['git', 'push', '-u', 'origin', branch_to_push])
+                response = execute(['git', 'remote', 'get-url', '--push', 'origin']).strip()
+                if response.startswith('https://'):
+                    if len(str(token)) == 0:
+                        raise Exception('GitHub token cannot be null or empty!')
+                    remote = response.replace('https://', 'https://' + token + ':x-oauth-basic@')
+                    execute(['git', 'push', '-u', remote, branch_to_push])
+                else:
+                    execute(['git', 'push', '-u', 'origin', branch_to_push])

script/pr.py

@@ -279,7 +279,7 @@ def main():
         return 1
 
     print('\nPushing local branches to remote...')
-    push_branches_to_remote(BRAVE_CORE_ROOT, config.branches_to_push, dryrun=config.is_dryrun)
+    push_branches_to_remote(BRAVE_CORE_ROOT, config.branches_to_push, dryrun=config.is_dryrun, token=config.github_token)
 
     try:
         print('\nCreating the pull requests...')