-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Labels
OS/iOSFixes related to iOS browser functionalityFixes related to iOS browser functionalityQA Pass - iPhoneQA/Yesrelease-notes/exclude
Milestone
Description
Description
The "Block Popups" setting found in General does not work correctly as it is reset/ignored when creating the initial WKWebViewConfiguration
s for each profile (javaScriptCanOpenWindowsAutomatically
set to false explicitly after recreating WKPreferences
)
configuration.preferences = WKPreferences()
configuration.preferences.javaScriptCanOpenWindowsAutomatically = false
These two lines should be removed
Steps to reproduce
- Visit a page that would automatically open a popup without user interaction
Actual result
Popup is always blocked
Expected result
Whether or not popup is opened should be based on the setting
Reproduces how often
Easily reproduced
Brave version
Broken for a super long time
Device/iOS version
n/a
Affected browser versions
- latest AppStore
- latest TestFlight
- previous TestFlight
Reproducibility
- with Brave Shields disabled
- in the latest version of mobile Safari
Miscellaneous information
No response
Metadata
Metadata
Assignees
Labels
OS/iOSFixes related to iOS browser functionalityFixes related to iOS browser functionalityQA Pass - iPhoneQA/Yesrelease-notes/exclude