Description
Description
With the new Nala theming work @aguscruiz has been doing, it should be possible for us to remove a bunch of the overriding logic we have in our brave_color_mixer and brave_tabs_color_mixer and just use the underlying colors from Chromium.
As an added bonus, this means we can enable the tri-color themes Chromium is using now before they remove support for the old dual color themes.
*Note:
As theming changes (especially to dark mode) are often controversial we should have a blog post explaining the changes.
Solid Color Themes
Existing users, who've picked one of the solid color themes will not be affected by these changes. However, if they change their theme color the only way to get the solid color theme back will be to install that theme from the Chrome Web Store.
Default Theme for New Users
By default Chromium sets the default theme to be the Gray/Blue theme. This is a bit different to the current default theme in Brave which is Gray/light gray. We should ensure that we default to the Gray/Gray theme.
Dark Theme Changes
This is likely to be the most controversial part of the change. The new dark theme is slightly lighter than the existing dark theme, and is inherited from upstream. This will make it significantly easier for us to maintain, and there will be far fewer override points after this change.
However, people are often pretty unhappy when the colors in their browser change. As a mitigation, in a blog post we should point users to the Just Black theme in the Chrome Web Store, which should result in a suitably dark theme.
cc @rebron & @aguscruiz for all the stuff I've forgotten to mention.
Approach
There are few parts to this change:
- Remove unnecessary overrides
- Enable Tri-Color themes by reverting patches
- Revert brave/brave-core@18090d1
- Revert brave/brave-core@4877e2f
- Ensure Gray/Gray theme is selected by default