Skip to content

Safety Check is warning about Passwords even though we disable that feature #39212

Closed
brave/brave-core
#24703
@fmarier

Description

Description

As reported in #12859 (comment), there is a very unhelpful message from Safety Check in brave://settings/privacy:
Screenshot from 2024-06-20 16-54-33

since the password block is hidden in brave://settings/safetyCheck.

I have confirmed that no network requests are triggered by this, so it may be a local check for bad passwords, I'm not sure.

Steps to reproduce

  1. Use a new browser profile.
  2. Go to brave://settings/privacy and scroll down to Safety Check.
  3. Confirm that it's not reporting anything.
  4. Go to brave://password-manager/passwords.
  5. Add a fake password for facebook.com: username = foo and password = bar (note: it appears to require a bad password to trigger).
  6. Go back to brave://settings/privacy and scroll down to Safety Check.

Actual result

Brave found some safety recommendations for your review
Passwords

Expected result

Brave regularly checks to make sure your browser has the safest settings. We'll let you know if anything needs your review.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave	1.68.92 Chromium: 126.0.6478.71 (Official Build) beta (64-bit)
Revision	393b9968e233540a48f04d74bc4601a05d3a0169
OS	Linux

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Metadata

Assignees

Type

No type

Projects

  • Status

    Completed

Relationships

None yet

Development

No branches or pull requests

Issue actions