Skip to content

Differentiate between mainnet and testnet in default account names #38526

Closed
brave/brave-core
#23815
@StephenHeaps

Description

Description

Currently there are different account types for Filecoin and Bitcoin, one for Mainnet and one for Testnet. Both currently use the same default name (no name entered), so it's

Steps to reproduce

  1. Switch to accounts tab
  2. Tap ... and tap Add Account
  3. Select Filecoin
    • Default should have Filecoin Mainnet selected
  4. Do not enter a name and tap Add
  5. Tap ... and tap Add Account again
  6. Select Filecoin
  7. Change network to Filecoin Testnet
  8. Do not enter a name, and tap Add

Actual result

Filecoin Account 1 (Mainnet account address starts with f) and Filecoin Account 2 (Testnet account starts with t) are created.

Expected result

Mainnet accounts still default to Filecoin Account #, where testnet accounts include Testnet.

Reproduces how often

Easily reproduced

Brave version

All with Filecoin support

Device/iOS version

iOS 15+

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

As part of work for #37740, we will be creating accounts automatically for networks selected during onboarding. As a result we may be creating Filecoin Mainnet & Filecoin Testnet accounts (or Bitcoin Mainnet & Bitcoin Testnet accounts). It's better we differentiate which is which, especially for Bitcoin which does not display an address to differentiate which is which.

Metadata

Assignees

Type

No type

Projects

  • Status

    Done

Relationships

None yet

Development

No branches or pull requests

Issue actions