Skip to content

Enable notifications from Brave to earn modal not appearing if All "Brave Ads" notifications disabled #27851

Closed
brave/brave-core
#16740
@kjozwiak

Description

Description

We should be showing the Enable notifications from Brave to earn Brave Rewards. modal when All "Brave Ads" notifications has been disabled but All Brave notifications is still enabled. With the current implementation, we're just checking All Brave notifications. However, a user could leave all their notifications enabled and just disable All "Brave Ads" notifications and still be able to enable rewards which puts them into the same state we tried to avoid with the Enable notifications from Brave to earn Brave Rewards. modal.

Steps to reproduce

  1. download/install 1.47.175 Chromium: 109.0.5414.87
  2. run through all the onboarding (can disable Notifications via this step if you're on Android 13
  3. go into Settings -> Notification and disable All Brave notifications
  4. once disabled, go back into the NTP and tap on the rewards panel
  5. select a country via the Country Selection and you'll notice you can't enable rewards due to notifications being disabled
  6. on the warning modal re: notifications being disabled, tap on Open Settings
  7. enable All Brave notifications but disable All "Brave Ads" notifications
  8. go back into the NTP and you'll notice you can now run through/enable rewards with notifications still disabled

Actual result

screen-20230117-012303.mp4

Expected result

Should be showing the following modal if a user has All "Brave Ads" notifications disabled and attempts to enable rewards:

image

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
  • Android version: Android 13

Brave version

Brave | 1.47.175 Chromium: 109.0.5414.87 (Official Build) (32-bit)
--- |  ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B2.221216.006

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@deeppandya @timchilds @sujitacharya2005 @Uni-verse

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions