Skip to content

discuss enabling TabbedPaintPreview only on lower end devices #25123

Closed
brave/brave-core
#15887

Description

Description

With C105, you'll notice Preview being displayed within the omnibox before the page finishes loading and then displays a modal/notification that says Viewing live page. What happens is that it loads an image in the view while the libraries are being loaded before letting the user know that they're viewing a live page.

@samartnik mentioned that this feature has been around for a while but is probably now appearing as it takes a bit longer for libraries to load on startup on C105, hence the Preview before loading the page. This feature is mostly tailored for lower end devices.

So we'll need to decide if we want to keep it as is for now or just enable it for lower end devices. However, if we do disable this for higher end devices and only enable it for lower device, someone with a higher end device could see a blank page while the libraries are loading rather than an Preview image.

Steps to reproduce

  1. open/launch any version of Brave that has C105
  2. open any website and leave it as the active tab
  3. close/re-launch Brave a few times until you see the Preview via the omnibox
  4. after a few ms, you'll notice a Viewing life page modal/notification in the middle of the viewport indicating the website loaded

Actual result

Screenshot_20220831-122755_Brave

Expected result

TBD and needs to be discussed/decided by product re: what we're going to do.

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung S10+ (Phone)
  • Android version: Android 12

Brave version

Brave | 1.43.87 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SP1A.210812.016

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? Yes

Additional information

CCing @timchilds @anthonypkeane @srirambv @samartnik @Uni-verse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

OS/AndroidFixes related to Android browser functionalityQA Pass - Android ARMQA/YesdesignA design change, especially one which needs input from the design teamneeds-discussionAlthough the issue is clear, we haven't yet reached a decision about the right solution.release-notes/include

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions