When Brave is re-installed with the same binary, the `Relaunch` button is shown in brave://settings/help although there is no update available

[MadhaviSeelam]

Description

As part of the testing of Omaha update to 1.3.36.111, tested install and re-install with same version. During first install, brave://settings/help page shows correct version (without update trigger). However, after re-install of the same binary, brave://settings/help page shows update trigger with Relaunch button. Fidler logs shows same omaha updater version 1.3.36.111 in both install and re-install. Same issue with current public release 1.40.105 Chromium: 103.0.5060.53 which has older Omaha version, 1.3.361.113.

Steps to Reproduce

1. Download BraveBrowserStandaloneBetaSetup.exe and install standalone binary (Beta v1.41.74 (Chromium 103.0.5060.53))
2. Go to brave://settings/help
3. Page renders Brave is up to date message (No update trigger)
4. Re-install same binary
5. Go to brave://settings/help

Actual result:

Nearly up to date! message shows with Relaunch button on the second install

Expected result:

Relaunch button should not be available if no updates available

Reproduces how often:

Easily

Brave version (brave://version info)

Brave	1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
Revision	a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS	Windows 11 Version 21H2 (Build 22000.739)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@mherrmann

[GeetaSarvadnya]

@mherrmann Could you please look into this issue, the issue exists on both the new/old Omaha versions. When we install the standalone/stub/silent installers, we get the brave is up to date in brave:///settings/help, if we re-install the same version, then we get Relaunch in brave://settings/help although there is no new update available. If we click on Relaunch we get the same existing version. According to me, we should not get Relaunch when there is no new update available.

[mherrmann]

My suspicion is that this also happens for Chrome.

[GeetaSarvadnya]

@mherrmann Yup, you are right. I am seeing the same behavior in chrome as well. Looks like an upstream bug?

[mherrmann]

I would say so, yes.

[GeetaSarvadnya]

@mkarolin @simonhong: It's an upstream bug, shall we keep this bug open until chrome fixes the issue? defer to @rebron to take the decision

cc: @LaurenWags @kjozwiak

[GeetaSarvadnya]

@mherrmann Could you please look into this issue, the issue exists on both the new/old Omaha versions. When we install the standalone/stub/silent installers, we get the brave is up to date in brave:///settings/help, if we re-install the same version, then we get Relaunch in brave://settings/help although there is no new update available. If we click on Relaunch we get the same existing version. According to me, we should not get Relaunch when there is no new update available.

[mherrmann]

My suspicion is that this also happens for Chrome.

[GeetaSarvadnya]

@mherrmann Yup, you are right. I am seeing the same behavior in chrome as well. Looks like an upstream bug?

[mherrmann]

I would say so, yes.

[GeetaSarvadnya]

@mkarolin @simonhong: It's an upstream bug, shall we keep this bug open until chrome fixes the issue? defer to @rebron to take the decision

cc: @LaurenWags @kjozwiak

[rebron]

@mherrmann Do you know what the upstream bug handy is? I'm not seeing it from this list https://bugs.chromium.org/p/chromium/issues/list?sort=-opened&q=relaunch%20button&can=2

[mkarolin]

I wonder if this is intentional. When you reinstall the same version while the current browser installation is still running the installer doesn't replace the executable on the drive. It instead writes out a new executable (named new_chrome). When you press Relaunch the old executable gets deleted and new_chrome gets renamed into brave.