Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated method Error::description #74

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Remove deprecated method Error::description #74

merged 1 commit into from
Apr 6, 2020

Conversation

antonok-edm
Copy link
Collaborator

Deprecated with rust-lang/rfcs#2230

AndriusA
AndriusA approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@AndriusA AndriusA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, assuming you've checked that it works with the compiler currently bundled with Brave build pipeline (1.35.0 I believe?)

@AndriusA AndriusA merged commit 2ae7b1c into master Apr 6, 2020
@AndriusA AndriusA deleted the deprecated-error-description branch April 6, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriusA AndriusA AndriusA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonok-edm @AndriusA