Update @rjsf/* to 5.22.4 #1744
Merged
Update @rjsf/* to 5.22.4 #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekBodingerBA
force-pushed
the
update-rjsf-5-22-4
branch
2 times, most recently
from
d0a577f
to
2b24ca6
Compare
MarekBodingerBA
force-pushed
the
update-rjsf-5-22-4
branch
from
2b24ca6
to
2bc81c1
Compare
…se "enum" everywhere and provide enumMetadata, remove support of number values in radio group (problematic and not used)
…us to join SelectMultiple + CheckboxGroup and Select + RadioGroup
MarekBodingerBA
force-pushed
the
update-rjsf-5-22-4
branch
from
2bc81c1
to
be4b111
Compare
…, the possibility to have number was removed as it doesn't make sense, and it is hard to cast to string safely, new ValueAdapter was created to handle conversion between boolean <-> string as react-aria RadioGroup only support string values, the previous logic (creating "value-1", "value-2") was cumbersome
MarekBodingerBA
force-pushed
the
update-rjsf-5-22-4
branch
from
be4b111
to
142f504
Compare
# Conflicts: # forms-shared/tests/definitions/__snapshots__/formDefinitions.ts.snap
mpinter
approved these changes
Nov 15, 2024
mpinter
added
pr: fix & ship 🚢
|
Test build pipeline info 🚀 🔜 forms-shared together with nest-forms-backend and next as those needs to be rebuild when forms-shared are changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is part of larger set of changes needed for #1715.
In order to have support for advanced conditions I managed to implement custom
experimental_customMergeAllOfto have super fast merging of conditional fields (the slowest part of RJSF right now):rjsf-team/react-jsonschema-form#4308
However the same update brought these two regression (or improvements 🤷?)
Consider reverting "Make fields with const pre-fiiled and readonly" rjsf-team/react-jsonschema-form#4344
There's temporary fix in c91c994
Unwanted default value for object field (regression introduced in 5.22.0) rjsf-team/react-jsonschema-form#4361
This is the major part of the PR, this led me to migrate all
anyOfs toenums. This is a good change, as it would increase our resilience to future RJSF changes. I managed to share previously atomized logic between 4 fields (select, select multiple, radio group, checkbox group) and between domains (schema generator, summary generator, RJSF widget components). As a part there's lot of needed refactoring and I also support for numeric values in radio group was removed (unused and problematic).Also, I wouldn't be confident to make such a change without extensive test coverage we have now so it helps us to move fast tremendously. In addition, Cypress tests helped me to find a serious issue during the development for the first time. 💪