Speedup pipelines on forms-shared with docker caching #1321
Conversation
|
not yet ready |
| @@ -28,9 +28,23 @@ jobs: | |||
| run: | | |||
| echo "Pipelines version: 2.3.0" | |||
|
|
|||
| - name: Set up QEMU | |||
| uses: docker/setup-qemu-action@v3 | |||
| - name: Build Docker image on test target | ||
| run: | | ||
| docker build -t test . | ||
| docker buildx build --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache -t test . |
There was a problem hiding this comment.
Is there a reason why are we doing this through CLI run command? Because as I see it this basically just wraps the docker build command for which we use official docker build action.
Also, doing docker cache like this is a bit unfortunate as this has a lot of implications. Most important one is a security issue that you are using public GitHub action storage (warning is what you want to read) to cache layers which are basically plain text files.
A better way would be to use some other build cache backend like registry and point it to our harbor, or if that wouldn't work to use S3, through their official GitHub action.
|
Converted to draft. |
|
hanks for the feedback, everyone. It was still in draft/testing mode. I hadn’t finished it before I left for vacation and forgot to change this PR to draft. I’ll let you know when everything is implemented. |
This PR adds support for caching of docker layers. It is related to bratislava/github-actions#30
After merge there needs to be updated a
stableanbetatags to make this change to take a effect.