refactor nodes.py:tree() #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR currently seems to include two unrelated changes to the module. Could you write up some discussion about them, and what would motivate each code change? |
This serves a purpose similar to type annotations.
It hides the insignificant variable `i`
to avoid remembering the order.
isidroas
force-pushed
the
refactor-nodes
branch
from
81f7f1c to
c42053b
Compare
|
Hi @brandon-rhodes thanks for the feedback! I have rewritten the history and now the branch is separated into 5 commits, each with an explanatory message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.