-
-
Notifications
You must be signed in to change notification settings - Fork 6
Implement Value Caching and Diffing for Optimized Change Detection #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Value Caching and Diffing for Optimized Change Detection #7
Conversation
|
@faizanu94 I’m not sure if you are looking for a review yet or not, but here goes: the core of this PR looks really good. The only thing that is missing is a flag to get back the old behavior, where an author can choose between getting only these The logic for that is similar to the flag you wrote in #1. (Once this PR is in, we can pick up #1 again to let users choose between the current simple format, or the more rich format) |
b2ad0f1 to
bb66704
Compare
|
Thanks for the reminder about taking care of the old behavior - I’ve added the flag |
Instead of a |
|
Thanks for the feedback! I've replaced the boolean flag with |
bramus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! In hindsight the INDIVIDUAL mode is incorrectly named, as it can report two changed properties at once.
I have made suggestions (which you can apply in the GitHub UI by simply clicking the button) to rename it to CHANGED_ONLY.
Also reworded the text in the README.
Co-authored-by: Bramus <bramus@bram.us>
Co-authored-by: Bramus <bramus@bram.us>
Co-authored-by: Bramus <bramus@bram.us>
Co-authored-by: Bramus <bramus@bram.us>
|
Thanks for the suggestions - I’ve applied the changes. Appreciate the guidance! |
This pull request introduces value caching and diffing mechanisms to optimize change detection. By caching previous values and diffing them against current values, we ensure that only the property that has changed is passed to the callback function as discussed in #1
Changes