Skip to content

Comments

🐛 do not throw when :is/:any/:matches do not contain children#14

Merged
bramus merged 2 commits intobramus:mainfrom
bartveneman:fix-empty-pseudoclasses
Dec 30, 2022
Merged

🐛 do not throw when :is/:any/:matches do not contain children#14
bramus merged 2 commits intobramus:mainfrom
bartveneman:fix-empty-pseudoclasses

Conversation

@bartveneman
Copy link
Contributor

This unifies behaviour between empty :is/:any/:matches pseudo-classes.

closes #12

@bartveneman
Copy link
Contributor Author

Not sure why the Lint Action errors, running linting and prettier locally works fine. Perhaps a permission issue?

@bramus bramus merged commit 973abdc into bramus:main Dec 30, 2022
@bramus
Copy link
Owner

bramus commented Dec 30, 2022

Thanks for this addition, Bart!

It’s the auto-commit that’s failing. Most likely a permissions thing indeed that I will need to look into in the future.

@bartveneman
Copy link
Contributor Author

't was me, linting failed, but the error message was a bit cryptic

@bartveneman bartveneman deleted the fix-empty-pseudoclasses branch December 30, 2022 16:03
@bramus
Copy link
Owner

bramus commented Dec 30, 2022

The build action lints the projects, and auto-commits the changes. Looking at https://github.com/bramus/specificity/actions/runs/3796868636/jobs/6457422335, it failed on the auto-commit step.

Had issues with this before (see ce42b3a) but looks like its back somehow ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different behavior between calculate(':where') and calculate(':is')

2 participants