-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Load Daniel font before rendering, provide default styling using inline css #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…after the theme is loaded and before diagram.drawSvg * Added support in snap theme to specify div name (compatible to Raphaël theme) * Fix Raphaël and Snap detection * Fixed unit test run
@@ -23,6 +23,7 @@ | |||
* License information: | |||
* http://creativecommons.org/licenses/by-nd/3.0/ | |||
*/ | |||
if (typeof Raphael !== "undefined") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I was being lazy :)
possible, but not required
…rawing - In the Snap hand theme the deviation to close to the ends caused the marker to be drawn at funny looking angles
After the window.load event diagrams can be rendered
I thought my in my first commit, the rendering of SVG was performed when the font was loaded. Only I forgot that I added the Font to the windows font store. This caused the Daniel font to load quickly on my PC. The current version uses an embedded stylesheet, which is possible to be overridden in the web page. What do you think of this solution? The current solution still needs:
What do you think is the way to go? |
Closed, because font rendering is supported in version 2 |
right after the theme is loaded and before diagram.drawSvg