Skip to content

Fix bt eval for ESM-only dependencies #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parkerhendo wants to merge 3 commits into
base: main
Choose a base branch
from
+303 −51
Open

Fix bt eval for ESM-only dependencies #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44933b4
test(js): add TypeScript eval test for ESM-only dependency
parkerhendo Feb 21, 2026
0863f43
feat(eval): add automatic ESM retry for CJS/ESM interop errors
parkerhendo Feb 23, 2026
ba6623b
fix(eval): skip ESM retry when runner override is set
parkerhendo Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/eval-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,10 +751,12 @@ function propagateInheritedBraintrustState(braintrust: BraintrustModule) {

async function loadFiles(files: string[]): Promise<unknown[]> {
const modules: unknown[] = [];
const forceEsm = envFlag("BT_EVAL_FORCE_ESM");
for (const file of files) {
const fileUrl = pathToFileURL(file).href;
const preferRequire =
file.endsWith(".ts") || file.endsWith(".tsx") || file.endsWith(".cjs");
!forceEsm &&
(file.endsWith(".ts") || file.endsWith(".tsx") || file.endsWith(".cjs"));

if (preferRequire) {
try {
Expand Down Expand Up @@ -799,6 +801,9 @@ async function loadFiles(files: string[]): Promise<unknown[]> {
}

function shouldTryRequire(file: string, err: unknown): boolean {
if (envFlag("BT_EVAL_FORCE_ESM")) {
return false;
}
if (process.env.BT_EVAL_CJS === "1" || file.endsWith(".cjs")) {
return true;
}
Expand Down
Loading
Loading