Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit paymentMethodRequestable event after 3DS Challenge is completed #917

Merged
merged 10 commits into from
Dec 20, 2023

Conversation

jplukarski
Copy link
Contributor

@jplukarski jplukarski commented Dec 18, 2023

Summary

Jira

Holds off sending the paymentMethodRequestable event until after verifyCard has completed for 3DS flows.

Addresses #805

Testing strategy:

Run the Drop-in demo in development mode and add the following query parameters to the URL in your browser:

?threeDSecure=true&authorization=<generate-a-client-token>

Then test each test card listed in our 3DS documentation to make sure everything works as expected on each flow. Open the dev console and notice that the event does not fire off until 3DS authentication is completed:

paymentMethodRequestable {paymentMethodIsSelected: true, type: 'CreditCard'}

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@jplukarski jplukarski marked this pull request as ready for review December 18, 2023 20:45
@jplukarski jplukarski requested a review from a team as a code owner December 18, 2023 20:45
src/dropin-model.js Outdated Show resolved Hide resolved
Copy link
Contributor

@hollabaq86 hollabaq86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first pass, but I don't think we cover all scenarios where 3DS "completes."

Why does 3DS have to be so complicated :lolsob:

src/dropin-model.js Outdated Show resolved Hide resolved
test/unit/dropin.js Outdated Show resolved Hide resolved
src/lib/three-d-secure.js Outdated Show resolved Hide resolved
jplukarski and others added 2 commits December 20, 2023 10:46
Co-authored-by: Holly Richko <hollis65@me.com>
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@hollabaq86 hollabaq86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chefskiss

@jplukarski jplukarski merged commit aab0587 into main Dec 20, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants