Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update plugins for ARM Mac #747

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Edouard2laire
Copy link
Contributor

@Edouard2laire Edouard2laire commented Nov 1, 2024

This PR updates the plugins for the ARM Mac:

We are very close to having all the plugins working for Mac with only Duneuro not being compatible.

@Edouard2laire
Copy link
Contributor Author

@rcassani, both iso2mesh contains a copy of jsnirfy. Is there a way to ensure that loadjsnirf.m, savejsnirf.m are coming from jsnirfy when loading snirf file?

Both files are the same now so there is no issue, but it might create issues in the future if they diverge

@Edouard2laire Edouard2laire changed the title update iso2mesh to 1.9.6 update iso2mesh to 1.9.8 Nov 1, 2024
@rcassani
Copy link
Member

rcassani commented Nov 1, 2024

This could addressed in two ways:

  1. Not allow iso2mesh to be loaded when jsnirfy is being loaded.
    Done by adding iso2mesh in the field UnloadPlugs for jsnirfy

  2. Removing the copy of jsnirfy from iso2mesh when this second is installed.
    We can add the plugin jsnirfy as dependency for iso2mesh, but this will cause troubles if they start to differ.

@Edouard2laire
Copy link
Contributor Author

Edouard2laire commented Nov 1, 2024

This could addressed in two ways:

  1. Not allow iso2mesh to be loaded when jsnirfy is being loaded.
    Done by adding iso2mesh in the field UnloadPlugs for jsnirfy

This was not working as jsnirfy was considered loaded when iso2mesh was. i think this is because the incompatible dependency were not unloaded before to try to laod a plugin:

bst_plugin('Load', 'iso2mesh');
bst_plugin('Load', 'jsnirfy');

would produce

BST> Adding plugin iso2mesh to path: /Users/edelaire1/.brainstorm/plugins/iso2mesh/iso2mesh-1.9.8
BST> Executing callback LoadedFcn: assignin('base', 'ISO2MESH_TEMP', bst_get('BrainstormTmpDir'));
BST> Plugin jsnirfy already loaded: /Users/edelaire1/.brainstorm/plugins/iso2mesh/iso2mesh-1.9.8

with the changes it now produces:

BST> Adding plugin iso2mesh to path: /Users/edelaire1/.brainstorm/plugins/iso2mesh/iso2mesh-1.9.8
BST> Executing callback LoadedFcn: assignin('base', 'ISO2MESH_TEMP', bst_get('BrainstormTmpDir'));
BST> Removing plugin iso2mesh from path: /Users/edelaire1/.brainstorm/plugins/iso2mesh/iso2mesh-1.9.8
BST> Plugin easyh5 already loaded: /Users/edelaire1/.brainstorm/plugins/easyh5
BST> Adding plugin jsnirfy to path: /Users/edelaire1/.brainstorm/plugins/jsnirfy/jsnirfy-master
BST> Adding plugin jsnirfy to path: /Users/edelaire1/.brainstorm/plugins/jsnirfy/jsnirfy-master/*

@Edouard2laire
Copy link
Contributor Author

Edouard2laire commented Nov 1, 2024

Note: I opened a PR to have xdf available on arm here: xdf-modules/xdf-Matlab#20 (NDLR: now merged)
Once this is merged there will only be duneneuro left not working on Mac with arm processors.

So maybe we should remove the warning at startup: https://github.com/brainstorm-tools/brainstorm3/blob/master/toolbox/core/bst_startup.m#L160-L164

@Edouard2laire Edouard2laire changed the title update iso2mesh to 1.9.8 update plugins for ARM Mac Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants