-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update plugins for ARM Mac #747
base: master
Are you sure you want to change the base?
Conversation
@rcassani, both iso2mesh contains a copy of jsnirfy. Is there a way to ensure that loadjsnirf.m, savejsnirf.m are coming from jsnirfy when loading snirf file? Both files are the same now so there is no issue, but it might create issues in the future if they diverge |
This could addressed in two ways:
|
This was not working as jsnirfy was considered loaded when iso2mesh was. i think this is because the incompatible dependency were not unloaded before to try to laod a plugin:
would produce
with the changes it now produces:
|
Note: I opened a PR to have xdf available on arm here: xdf-modules/xdf-Matlab#20 (NDLR: now merged) So maybe we should remove the warning at startup: https://github.com/brainstorm-tools/brainstorm3/blob/master/toolbox/core/bst_startup.m#L160-L164 |
This PR updates the plugins for the ARM Mac:
iso2mesh to 1.9.8
A new version of iso2mesh was released last week by @fangq notably adding the support for arm computer.
The details of the changes can be seen here: https://github.com/fangq/iso2mesh/releases/tag/v1.9.8
This updates the plugin version of iso2mesh to this new release.
xdf to master.
xdf is now working on ARM Mac. (see Recompile for Mac with arm processor xdf-modules/xdf-Matlab#20)
Improve the support of conflict between plugins
We are very close to having all the plugins working for Mac with only Duneuro not being compatible.