Global use of must_xxx is deprecated #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashirosota
changed the title
tashirosota
changed the title
tashirosota
force-pushed
the
fix/deprecated_must_bar
branch
from
c21ce9c to
58d99a9
Compare
tashirosota
changed the title
tashirosota
changed the title
tashirosota
changed the title
tashirosota
force-pushed
the
fix/deprecated_must_bar
branch
2 times, most recently
from
4a38244 to
270ea6e
Compare
tashirosota
commented
Mar 6, 2021
| begin | ||
| # Checks first if the enumerized attribute is in ActiveRecord::Store | ||
| store_attr, _ = reloaded.class.stored_attributes.detect do |store_attr, keys| | ||
| store_attr, _ = reloaded.class.stored_attributes.detect do |_store_attr, keys| |
Contributor
Author
There was a problem hiding this comment.
warning: shadowing outer local variable - store_attr
tashirosota
changed the title
Contributor
Author
|
@nashby |
Member
|
@tashirosota hey! Thanks for this! Could you please squash these commits into one? |
tashirosota
force-pushed
the
fix/deprecated_must_bar
branch
from
47a0167 to
81f6aa9
Compare
tashirosota
force-pushed
the
fix/deprecated_must_bar
branch
from
81f6aa9 to
034d1c8
Compare
Contributor
Author
|
@nashby |
Member
|
@tashirosota thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPRECATED: global use of must_xxx
Change
hoge.must_be pagetoexpect(hoge).must_be page