Implement new navigation for website #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Deploying brainless-in with
|
| Latest commit: |
c1eb6a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de07af87.brainless-in.pages.dev |
| Branch Preview URL: | https://feature-issue-23-navigation.brainless-in.pages.dev |
|
Fixed the mobile menu issue. The problem was that the JavaScript was not properly initializing in the Astro component-based architecture. I've updated the mobile-menu.js file to handle cases where elements might not be immediately available and to work with Astro's view transitions. The mobile menu should now open correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new navigation as described in issue #23:\n\n- Added desktop navigation component with recent blog posts, projects, and videos\n- Added mobile navigation with overlay menu\n- Updated layouts to accommodate the new navigation\n- Increased content width for larger screens\n\nPlease review and test the implementation.