Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QT setup in tests #15

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix QT setup in tests #15

merged 1 commit into from
Mar 16, 2022

Conversation

dstansby
Copy link
Member

This is now what napari recommends to setup QT in a test run. Hopefully this should fix the tests that are failing in #13

@dstansby dstansby mentioned this pull request Mar 16, 2022
Merged
@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/brainglobe/brainglobe-napari-io/15

@dstansby dstansby requested a review from a team March 16, 2022 11:23
alessandrofelder
alessandrofelder approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link to the relevant docs/resources in the PR description, please, for future reference?
Otherwise, LGTM.

@dstansby
Copy link
Member Author

My bad - for reference this change was taken from the current cookiecutter-napari-plugin github actions workflow: https://github.com/napari/cookiecutter-napari-plugin/blob/b1e91b30c2e4b01574638f9972ebb3c726b5cc75/.github/workflows/test.yml#L30-L31

@alessandrofelder alessandrofelder merged commit f928de0 into brainglobe:master Mar 16, 2022
@dstansby dstansby deleted the test-qt-setup branch March 16, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @alessandrofelder