-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UTF-8 encoding problem #745
Fix UTF-8 encoding problem #745
Conversation
Hi, not sure I understand the problem and solution here. Could you share the output of compilation with the error? Is it simpleble which fails to build? |
Sorry for the late reply. C:\Users\cheongpark\Downloads\brainflow\tools>python build.py --ble Running command: cmake -DCMAKE_INSTALL_PREFIX=C:\Users\cheongpark\Downloads\brainflow\tools..\installed -DCMAKE_SYSTEM_VERSION=8.1 -DBRAINFLOW_VERSION=0.0.1 -G Visual Studio 17 2022 -A x64 -DMSVC_RUNTIME=static -DBUILD_BLUETOOTH=ON -DBUILD_BLE=ON C:\Users\cheongpark\Downloads\brainflow\tools.. 1>Checking Build System C:\Users\cheongpark\Downloads\brainflow\third_party\fmt\include\fmt\chrono.h(1,1): warning C4819: (949) . . [C:\Users\cheongpark\Downloads\brainflow\build\third_party\SimpleBLE\simpleble\simpleble.vcxproj] AdapterSafe.cpp |
ok, I see, its from fmt which is used by simpleble |
Traceback (most recent call last): File "C:\Users\cheongpark\brainflow\tools\build.py", line 309, in <module> main() File "C:\Users\cheongpark\brainflow\tools\build.py", line 305, in main build(args) File "C:\Users\cheongpark\brainflow\tools\build.py", line 290, in build run_command(cmd_build, cwd=args.build_dir) File "C:\Users\cheongpark\brainflow\tools\build.py", line 22, in run_command raise ValueError('Process finished with error code %d' % p.returncode) ValueError: Process finished with error code 1
When building with the
--ble
option on Windows in languages such as Korean or Japanese, an error like the one above occurs. This error seems to happen if the "Beta: Use Unicode UTF-8 for worldwide language support" option is not enabled. Enabling the committed option seems to resolve the issue for now.