Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the the get gain command #735

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

Sarthak031
Copy link
Contributor

No description provided.

@@ -190,6 +192,7 @@ int BrainAlive::prepare_session ()
if ((res == (int)BrainFlowExitCodes::STATUS_OK) && (control_characteristics_found))
{
initialized = true;
config_board ("0a036007000d");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add check for result here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it should be res =... and below that initialized = true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

command[4] = 0x0d;
safe_logger (spdlog::level::trace, config[2]);
// Calculate the number of bytes
size_t numBytes = config.length () / 2; // Each byte is represented by 2 hex characters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is snake case with _ for variables everywhere in brainflow, lets keep it consistent

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to all variables in this block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Andrey1994
Copy link
Member

Andrey1994 commented Aug 2, 2024

I also dont get why you need to config board multiple times and what these configs mean, but that board speciffic part is up to your device to determine

@Sarthak031
Copy link
Contributor Author

I also dont get why you need to config board multiple times and what these configs mean, but that board speciffic part is up to your device to determine

The first config is for start data streaming, the second config is used for stop data streaming, and the third is used to get the configuration of the device before data streaming.

@Andrey1994 Andrey1994 merged commit 70e18d7 into brainflow-dev:master Aug 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants