-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the the get gain command #735
Added the the get gain command #735
Conversation
@@ -190,6 +192,7 @@ int BrainAlive::prepare_session () | |||
if ((res == (int)BrainFlowExitCodes::STATUS_OK) && (control_characteristics_found)) | |||
{ | |||
initialized = true; | |||
config_board ("0a036007000d"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add check for result here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it should be res =... and below that initialized = true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
command[4] = 0x0d; | ||
safe_logger (spdlog::level::trace, config[2]); | ||
// Calculate the number of bytes | ||
size_t numBytes = config.length () / 2; // Each byte is represented by 2 hex characters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is snake case with _ for variables everywhere in brainflow, lets keep it consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applies to all variables in this block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I also dont get why you need to config board multiple times and what these configs mean, but that board speciffic part is up to your device to determine |
The first config is for start data streaming, the second config is used for stop data streaming, and the third is used to get the configuration of the device before data streaming. |
No description provided.