Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log message for EOF in PlaybackFileBoard. #663

Conversation

stellarpower
Copy link
Contributor

BrainFlow's stream doesn't block, so, the user calling into the session has to use some other method - sleeping, or waiting for user input before terminating the session.

When playing back a file, and not looping, it's possible the file will ned before the user is expecting. At this point, the file reader will sleep, but no message is printed, so the pipeline silently stops sending values.

This simply adds a logging line for when the file playback virtual board has reached the end of file and stops producing data.

BrainFlow's stream doesn't block, so, the user calling into the session has to use some other method - sleeping, or waiting for user input before terminating the session.

When playing back a file, and not looping, it's possible the file will ned before the user is expecting. At this point, the file reader will sleep, but no message is printed, so the pipeline silently stops sending values.

This simply adds a logging line for when the file playback virtual board has reached the end of file and stops producing data.
@Andrey1994
Copy link
Member

https://brainflow.readthedocs.io/en/stable/BrainFlowDev.html#code-style

To fix failed ci job

Also failed job prints the diff

@stellarpower
Copy link
Contributor Author

The instructions there don't say how to run clang-format, so it might be worth adding something that can be pasted into the command-line. I have installed clang-format and given it the same argument as were used in the CI check and it's not happy, it looks that most of the options have been removed, so I just gave up and pasted the patch lines back into the browser. From work I also believe some colleagues have used more recent versions and that could apply changes re casing and identifier names, so may be of use for you.

@Andrey1994 Andrey1994 merged commit a584036 into brainflow-dev:master Aug 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants