Skip to content

Updating Models to reflect new attributes added by MLB #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bradleyhurley wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updating Models to reflect new attributes added by MLB #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1e8e85
Updating Models to reflect new attributes added by MLB
bradleyhurley Jun 29, 2020
f248199
mend
bradleyhurley Jun 29, 2020
d0e575d
Fixing flake8 issues
bradleyhurley Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyball/models/config/position.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ class Position:
fielder: bool = None
displayName: str = None
formalName: str = None # noqa: E701
gamePosition: bool = None
1 change: 1 addition & 0 deletions pyball/models/team/coach.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class Coach:
jerseyNumber: str = None
job: str = None
jobId: str = None
title: str = None

def __post_init__(self):
self.person = Person(**self.person)
15 changes: 1 addition & 14 deletions test/test_draft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
from pyball.models.generic_team import Team
from pyball.models import Person

from pyball.exceptions import BadRequestError, NotFound
from pyball.constants import BASE_URL
from pyball.exceptions import BadRequestError


@pytest.fixture(scope='module')
Expand Down Expand Up @@ -59,15 +58,3 @@ def test_bad_draft_year():
pyball = PyBall()
with pytest.raises(BadRequestError):
pyball.get_draft_by_year("BadYear")


def test_get_not_found_draft():
pyball = PyBall()
with pytest.raises(NotFound):
pyball._get("{}/draft".format(BASE_URL))


def test_get_not_found_draft_prospects():
pyball = PyBall()
with pytest.raises(NotFound):
pyball._get("{}/draft/prospects".format(BASE_URL))