[CLOSED] Disable and enable extensions

[core-ai-bot]

Issue by busykai
Saturday May 30, 2015 at 22:55 GMT
Originally opened as adobe/brackets#11184

---

This PR provides a simple mechanism to disable and enable again an extension and complete support of the functionality in the Extension Manager.

Extension loader looks for .disabled file in the extension directory, if it's present the information is included and propagated to the entire extensibility subsystem. Extension Manager can disable and enable extensions using the same mechanism.

---

busykai included the following code: https://github.com/adobe/brackets/pull/11184/commits

[core-ai-bot]

Comment by busykai
Sunday May 31, 2015 at 01:26 GMT

---

CC:@albertinad, you made me do it. now you have to review it. :)

[core-ai-bot]

Comment by mackenza
Sunday May 31, 2015 at 01:34 GMT

---

Good stuff. As I mentioned on Slack, I think the .disabled file is a great, simple way of using convention over configuration to make this work. So I definately appreciate that.

Unless I am missing something, or maybe behaviour is different on Linux (Ubuntu 14.04 x64 here), but I don't see how you can enable a disabled extension. I was expecting an Enable button in my "Installed" list in Extension Manager.

[core-ai-bot]

Comment by busykai
Sunday May 31, 2015 at 01:37 GMT

---

Unless I am missing something, or maybe behaviour is different on Linux (Ubuntu 14.04 x64 here), but I don't see how you can enable a disabled extension. I was expecting an Enable button in my "Installed" list in Extension Manager.

This sounds as a bug. Checked, it should be Enable. Somehow it regressed while I was writing tests. :( Will fix.

[core-ai-bot]

Comment by mackenza
Sunday May 31, 2015 at 01:43 GMT

---

My disabled extensions show up in the list, but the buttons all say Disable

[core-ai-bot]

Comment by busykai
Sunday May 31, 2015 at 02:03 GMT

---

@mackenza, fixed it (slightly blushing).

[core-ai-bot]

Comment by TomMalbran
Sunday May 31, 2015 at 03:15 GMT

---

You need to unmark all extensions that were marked to be disabled after this line (https://github.com/adobe/brackets/blob/kai/disable-enable-extensions/src/extensibility/ExtensionManagerDialog.js#L209).

[core-ai-bot]

Comment by zaggino
Sunday May 31, 2015 at 07:57 GMT

---

question: will this work for default extensions? if so, can we add .disabled to .gitignore file?

[core-ai-bot]

Comment by busykai
Sunday May 31, 2015 at 13:33 GMT

---

@zaggino, it will work on default extensions via manually creating and deleting .disabled file.

@TomMalbran, thanks for the thorough review will fix these.

[core-ai-bot]

Comment by mackenza
Sunday May 31, 2015 at 17:02 GMT

---

@zaggino@busykai I went into /src/extensions/default/CodeFolding, did a touch .disabled and reloaded Brackets and, indeed, no code folding.

[core-ai-bot]

Comment by zaggino
Sunday May 31, 2015 at 22:08 GMT

---

@busykai great, can you add an .disabled entry to the https://github.com/adobe/brackets/blob/master/.gitignore then?

[core-ai-bot]

Comment by busykai
Monday Jun 01, 2015 at 01:21 GMT

---

@zaggino, you're right. Will add this file to .gitignore.

[core-ai-bot]

Comment by busykai
Monday Jun 01, 2015 at 01:43 GMT

---

Did some more testing, focused on error handling. Seems to be fine now.

[core-ai-bot]

Comment by rroshan1
Wednesday Jun 17, 2015 at 07:59 GMT

---

With an update available for an extension, the buttons look like this (refer first extension):-

We can either have all 3 bttons in same line or just update in separate line..

[core-ai-bot]

Comment by rroshan1
Wednesday Jun 17, 2015 at 08:12 GMT

---

@busykai I really liked this feature. Enabling and disabling of extensions is super smooth now. 👍
All unit tests pass and I have reviewed the PR from my side and shared my comments.
Can you please update ".disabled" entry in the .gitignore file to more specific "src/extensions/default/*/.disabled" and address my comments and we should be all ready to have this PR merged soon. 😄

[core-ai-bot]

Comment by busykai
Friday Jun 19, 2015 at 12:11 GMT

---

@rroshan1, thanks for the review. I'll get to this real soon. I'm not sure what to do with the buttons, though...@larz0, would you recommend a direction? Perhaps, stack them vertically instead (always). Or not show the disable button when there's an update (not good). Or increase the size of the dialog...