[CLOSED] Add deprecation warning for convertPreferences()

[core-ai-bot]

Issue by le717
Wednesday May 27, 2015 at 16:45 GMT
Originally opened as adobe/brackets#11174

---

For #10412.

@nethip Any suggestions for the message wording?

---

le717 included the following code: https://github.com/adobe/brackets/pull/11174/commits

[core-ai-bot]

Comment by le717
Friday Jun 12, 2015 at 15:48 GMT

---

@nethip Suggested change made, ready to go.

[core-ai-bot]

Comment by MarcelGerber
Saturday Jun 13, 2015 at 21:52 GMT

---

Could you also add the @deprecated JSDoc to getPreferenceStorage?

[core-ai-bot]

Comment by le717
Sunday Jun 14, 2015 at 19:20 GMT

---

@MarcelGerber All changes made.

[core-ai-bot]

Comment by MarcelGerber
Saturday Jun 20, 2015 at 05:51 GMT

---

The messages are still not quite streamlined, but as it's unlikely, for an end user, to get both at the same time, I'll merge anyway.

[core-ai-bot]

Comment by sprintr
Tuesday Jul 07, 2015 at 00:15 GMT

---

PreferencesManager.convertPreferences is still being used in the core in src/utils/Resizer.js. I think it should be safe to remove it. _isPanelPreferences should be removed as well.

Edit: There are more than one instance where it is being used.

[core-ai-bot]

Comment by le717
Thursday Jul 16, 2015 at 14:31 GMT

---

@sprintr Apologies for what's probably a dumb question, but how exactly would that be updated? Resizer is a core (but not core extension) module, but I have never seen a panelState key in the preferences file.