[CLOSED] [#10228] Cmd+Delete now triggers Don't Save in Save Changes dialog

[core-ai-bot]

Issue by lucaslouca
Saturday Jan 24, 2015 at 16:33 GMT
Originally opened as adobe/brackets#10459

---

Cmd+Delete (Mac) now triggers Don't Save in Save Changes dialog. This is the system's default behaviour (see http://support.apple.com/en-us/HT201236).

(Issue #10228)

---

lucaslouca included the following code: https://github.com/adobe/brackets/pull/10459/commits

[core-ai-bot]

Comment by peterflynn
Sunday Mar 01, 2015 at 07:57 GMT

---

@lucaslouca It sounds like some Mac apps use Cmd-D also (e.g. #283 mentions this), so this should probably be ||ed with the original check.

Also, could you squash this down to one commit? 3-4 commits for a single-line change makes the git history a little sloppy.

Looks great otherwise though!

[core-ai-bot]

Comment by peterflynn
Sunday Mar 01, 2015 at 08:04 GMT

---

Ah, I forgot that the existing Cmd-D code has been broken for a long time, due to conflicting with a menubar shortcut (see #4135 / scoped keybindings story). So this actually looks fine as is -- if you can just squash the commits, I think we can go ahead & merge.

[core-ai-bot]

Comment by lucaslouca
Sunday Mar 01, 2015 at 08:34 GMT

---

Hello,

done :)

On 2015-03-01 09:04, Peter Flynn wrote:

Ah, I forgot that the existing Cmd-D code has been broken for a long
time, due to conflicting with a menubar shortcut (see #4135 [1] /
scoped keybindings story [2]). So this actually looks fine as is -- if
you can just squash the commits, I think we can go ahead & merge.

Reply to this email directly or view it on GitHub [3].

Links:

[1] adobe/brackets#4135
[2]
https://trello.com/c/I07x1pO0/1002-more-flexible-context-sensitive-scoped-key-event-handling
[3] adobe/brackets#10459 (comment)

[core-ai-bot]

Comment by peterflynn
Tuesday Mar 03, 2015 at 07:57 GMT

---

Looks good -- thanks!