[CLOSED] Debounce calls to ProjectManager._renderTree.

[core-ai-bot]

Issue by dangoor
Monday Dec 08, 2014 at 21:39 GMT
Originally opened as adobe/brackets#10120

---

This is a possible fix for #9851. In my tests, this can cause a
dramatic speed up when lots of filesystem changes cause the tree
to be continuously rerendered.

I chose 100ms as the debounce time because that seemed quick enough that
users will not be waiting for their actions to be reflected in the tree.

---

dangoor included the following code: https://github.com/adobe/brackets/pull/10120/commits

[core-ai-bot]

Comment by redmunds
Tuesday Dec 09, 2014 at 00:05 GMT

---

The following WorkingSetView Integration test is failing:

"should show the file in project tree when a file is being renamed"

Error: Expected undefined to be 'file_two.js'.
    at new jasmine.ExpectationResult (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/thirdparty/jasmine-core/jasmine.js:114:32)
    at null.toBe (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/thirdparty/jasmine-core/jasmine.js:1235:29)
    at null.<anonymous> (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/spec/WorkingSetView-test.js:268:70)
    at jasmine.Block.execute (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/thirdparty/jasmine-core/jasmine.js:1064:17)
    at jasmine.Queue.next_ (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/thirdparty/jasmine-core/jasmine.js:2096:31)
    at jasmine.Queue.start (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/thirdparty/jasmine-core/jasmine.js:2049:8)
    at jasmine.Spec.execute (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/thirdparty/jasmine-core/jasmine.js:2376:14)
    at jasmine.Queue.next_ (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/thirdparty/jasmine-core/jasmine.js:2096:31)
    at onComplete (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/thirdparty/jasmine-core/jasmine.js:2092:18)
    at jasmine.Spec.finish (file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/thirdparty/jasmine-core/jasmine.js:2350:5)

[core-ai-bot]

Comment by redmunds
Tuesday Dec 09, 2014 at 00:52 GMT

---

@dangoor Done with review. I verified Brackets is now much more responsive with massive changes to file tree (which I tested using git). Just need to fix 1 unit test.

[core-ai-bot]

Comment by dangoor
Tuesday Dec 09, 2014 at 14:38 GMT

---

Test fixed. Ready for re-review.

[core-ai-bot]

Comment by redmunds
Tuesday Dec 09, 2014 at 16:05 GMT

---

Done with review. I don't think we need new function and there's a Travis JSHint error.

[core-ai-bot]

Comment by dangoor
Tuesday Dec 09, 2014 at 19:52 GMT

---

Ugh, my email is coming through delayed by a few hours right now. I didn't realize Jasmine had waits. I've changed to using that. I've also fixed the JSHint error.

[core-ai-bot]

Comment by redmunds
Tuesday Dec 09, 2014 at 21:25 GMT

---

Merging.