[CLOSED] Semi-fix bug #10013 (CSS Quick Edit provider does not respond if project contains any non-UTF8 CSS/LESS/SCSS files)

[core-ai-bot]

Issue by peterflynn
Tuesday Dec 02, 2014 at 00:53 GMT
Originally opened as adobe/brackets#10052

---

Semi-fix for bug #10013 -- Silently ignore files that can't be read, and continue the search anyway (warning logged to console, but no user-visible error shown). Similar to what we've always done for Find in Files.

With unit test, and matching test for the pre-existing same behavior in Find in Files. Also clean up dated use of waitsFor() in the CSSUtils test spec.

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/10052/commits

[core-ai-bot]

Comment by busykai
Tuesday Dec 02, 2014 at 18:18 GMT

---

@peterflynn, JSHint complains:

Running "jshint:all" (jshint) task

Linting test/spec/CSSUtils-test.js...ERROR

[L1922:C30] W098: 'rules' is defined but never used.

var rules;

Linting test/spec/CSSUtils-test.js...ERROR

[L25:C115] W098: 'spyOn' is defined but never used.

/*global define, describe, it, expect, beforeEach, afterEach, waitsForDone, runs, beforeFirst, afterLast, spyOn */

[core-ai-bot]

Comment by peterflynn
Tuesday Dec 02, 2014 at 23:46 GMT

---

Whoops, sorry about the JSHint snags... I sure hope we can migrate fully onto it soon.

@busykai Changes pushed that I think address all of your comments above. Please lmk if not.

[core-ai-bot]

Comment by busykai
Wednesday Dec 03, 2014 at 02:52 GMT

---

@peterflynn, no worries about JSHint -- #7362 is coming and will help in these cases!

[core-ai-bot]

Comment by peterflynn
Wednesday Dec 03, 2014 at 19:35 GMT

---

@busykai Let me know if you think this needs any other changes to merge?

[core-ai-bot]

Comment by busykai
Wednesday Dec 03, 2014 at 19:57 GMT

---

Tested. Much better diagnostics. Looks good to me. Merging.

[core-ai-bot]

Comment by peterflynn
Wednesday Dec 03, 2014 at 19:59 GMT

---

Thanks!