[CLOSED] Adding input types to focusable elements #9476

[core-ai-bot]

Issue by eliezerb
Thursday Nov 13, 2014 at 04:32 GMT
Originally opened as adobe/brackets#9915

---

This pull-request contains the patch to fix the issue #9476.

Making possible to the user give focus on input fields inside elements with no-focus class.

---

eliezerb included the following code: https://github.com/adobe/brackets/pull/9915/commits

[core-ai-bot]

Comment by peterflynn
Thursday Nov 13, 2014 at 07:54 GMT

---

As I mentioned on IRC, I think it would be much simpler but equally correct to just filter on $target.is("input") overall -- no need to check the type. On platforms where clicking e.g. a checkbox shouldn't give it focus, Chromium should already be behaving that way by default anyway, so it shouldn't matter if we don't call preventDefault() for it.

[core-ai-bot]

Comment by eliezerb
Thursday Nov 13, 2014 at 11:35 GMT

---

@peterflynn Thanks for the tip. I replaced the specific input types with the general input tag. I think this matches with your suggestion.

[core-ai-bot]

Comment by redmunds
Tuesday Dec 02, 2014 at 23:54 GMT

---

It seems this code doesn't really do much anyway. It only applies to elements with no-focus class (i.e. doesn't apply to elements inside a no-focus element), and it only prevents mousedown (i.e. you can still Tab to element). This is all the more reason to simplify this code.

Thanks. Merging.

[core-ai-bot]

Comment by peterflynn
Wednesday Dec 03, 2014 at 23:37 GMT

---

@redmunds It definitely does apply to elements inside a no-focus parent, because mousedown events bubble. We rely on that in many places, including the toolbars, status bar, and Find in Files results panel.

You're right that it does not affect tabbing, though. A better name for it might be .no-mousedown-focus -- although if we eventually implement global focus management to control tabbing, it could presumably look at the same CSS class, so maybe the more generic name is actually good for future-proofing.

[core-ai-bot]

Comment by redmunds
Thursday Dec 04, 2014 at 18:00 GMT

---

@peterflynn

It definitely does apply to elements inside a no-focus parent...

You're right. I assumed that the test modal dialog I created was contained in a no-focus parent, but it wasn't.