-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Issue by redmunds
Thursday Jul 31, 2014 at 15:24 GMT
Originally opened as adobe/brackets#8605
The simple recipe in #7886 uncovers a big design flaw in live preview where docs not in the working set don't work. I suspect that many reported problems and open issues are related to this subtle difference.
The issue is that live preview caches HTMLDocument objects, but the Document and Editor objects that it references are only maintained when doc is in the working set. When doc is not in the working set, a new Document and Editor object is created every time it is selected in project tree.
This PR makes 2 changes:
- HTMLDocument now ref counts
this.docDocument so it persists while Live Preview is connected. - HTMLDocument now listens for
activeEditorChangeevent to handle Editor changes. This includes proper updating of event listeners and HTMLInstrumentation.
redmunds included the following code: https://github.com/adobe/brackets/pull/8605/commits
Metadata
Metadata
Assignees
Labels
No labels